Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
How to QA
Open browser devtools Console tab.
Go to https://snapcraft-io-5626.demos.haus/
Console: [analytics] trackPageView: snap_home_page
Type "firefox" in the search box and press Enter
Console: [analytics] snap_home_search_submitted {search_id: "...", query: "firefox"}
Page navigates to /store?q=firefox
After navigation, check console
Console: [analytics] trackPageView: snap_store_page
After results appear on screen
Console: [analytics] snap_store_search_results_loaded {search_id: "...", query: "firefox", total_items: ..., page: "1"}
Verify search_id matches step 5
Click on any snap card
Console: [analytics] snap_store_search_result_clicked {search_id: "...", query: "firefox", position: ...}
Verify search_id matches step 5
Go to /store
Type "vlc" in the search box and press Enter
Console: [analytics] snap_store_search_submitted {search_id: "...", query: "vlc"}
Verify search_id is different from step 5 (new search = new ID)
Console: [analytics] snap_store_search_results_loaded {search_id: "...", query: "vlc", ...}
Verify search_id matches the new one from step 5
On /store, type "xyzqwerty123456" and press Enter
Console: [analytics] snap_store_search_submitted {search_id: "...", query: "xyzqwerty123456"}
Console: [analytics] snap_store_search_no_results {search_id: "...", query: "xyzqwerty123456"}
Verify empty results page is shown
Verify all events within a single search journey share the same search_id
Start a new search
verify a new search_id is generated
Known limitations
Testing
Security
Issue / Card
Fixes #
UX Approval