Skip to content

fix: add explicit vitest/vite resolution#5658

Merged
edisile merged 1 commit intomainfrom
vitest-resolutions-fix
Apr 8, 2026
Merged

fix: add explicit vitest/vite resolution#5658
edisile merged 1 commit intomainfrom
vitest-resolutions-fix

Conversation

@edisile
Copy link
Copy Markdown
Contributor

@edisile edisile commented Apr 8, 2026

Done

added explicit vitest/vite resolution to 7.3.2 (vitest 4.1.3 installs vite 8 as a dependency and might lead to issues, as pointed out by copilot here)

How to QA

  • check that demo runs
  • check that CI is green

Testing

  • This PR has tests
  • No testing required (explain why):

Security

  • Security considerations for review (list them):
    • Examples:
    • Access control: users can only access their own data
    • Input: user input is validated and sanitised
    • Sensitive data: secret or private data is not exposed in any way
    • ...
  • This PR has no security considerations (explain why):

Issue / Card

Fixes #

Screenshots

UX Approval

  • This PR does not require UX approval
  • This PR does require UX approval (add context):

Copilot AI review requested due to automatic review settings April 8, 2026 13:41
@webteam-app
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins Vitest’s transitive Vite dependency to the repo’s Vite 7 baseline to avoid Vitest pulling in Vite 8, keeping the frontend toolchain consistent for builds and tests.

Changes:

  • Add a Yarn resolution to force vitestvite to 7.3.2.
  • Update yarn.lock to remove the Vite 8 subtree and dedupe to Vite 7.3.2.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Adds resolutions.vitest/vite = 7.3.2 to prevent Vitest from installing Vite 8.
yarn.lock Reflects the resolution by collapsing Vite to 7.3.2 and removing Vite 8-related transitive deps.

Comment thread package.json
@edisile edisile merged commit b72dff4 into main Apr 8, 2026
18 checks passed
@edisile edisile deleted the vitest-resolutions-fix branch April 8, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants