extract package details header to its own directory#5662
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Snap “package details” header templates by moving the header-related macros into a dedicated templates/store/package_header/ directory to keep the logic co-located and easier to reuse elsewhere (e.g. Charmhub), without intended behavior changes.
Changes:
- Updated store templates to import
package_headerfrom the newstore/package_header/location. - Introduced a new
templates/store/package_header/directory containing the extracted header macros. - Adjusted internal macro imports within the header components to use the new paths.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| templates/store/snap-distro-install.html | Updates the package_header macro import path to the new directory. |
| templates/store/snap-details.html | Updates the package_header macro import path to the new directory. |
| templates/store/package_header/_package_header.html | New home for the package_header macro, now importing header helpers from the new directory. |
| templates/store/package_header/_package_header_data.html | Updates internal imports to reference the new package_header sub-macros. |
| templates/store/package_header/_developer_info.html | New extracted macro for rendering developer info with tooltip styling. |
| templates/store/package_header/_publisher_info.html | New extracted macro for rendering publisher info and validation badges. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
How to QA
Testing
Security
Issue / Card
Fixes WD-24035
UX Approval