Skip to content

prevent false featured snaps indicators#5673

Merged
ilayda-cp merged 3 commits intomainfrom
WD-36121-tracking-fix
Apr 17, 2026
Merged

prevent false featured snaps indicators#5673
ilayda-cp merged 3 commits intomainfrom
WD-36121-tracking-fix

Conversation

@ilayda-cp
Copy link
Copy Markdown
Contributor

@ilayda-cp ilayda-cp commented Apr 17, 2026

Done

/store?categories=featured&q=foo ==> featured
/store?page=3&categories=featured --> featured
/store --> featured
/store?page=2 --> featured
/store?page=2&q=ubuntu --> not featured
/store?page=2&categories=games --> not featured

How to QA

NA

Testing

  • This PR has tests
  • No testing required (explain why):

Security

  • Security considerations for review (list them):
    • Examples:
    • Access control: users can only access their own data
    • Input: user input is validated and sanitised
    • Sensitive data: secret or private data is not exposed in any way
    • ...
  • This PR has no security considerations (explain why):

Issue / Card

Fixes #

Screenshots

UX Approval

  • This PR does not require UX approval
  • This PR does require UX approval (add context):

@webteam-app
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ilayda-cp ilayda-cp merged commit c2b44ee into main Apr 17, 2026
14 checks passed
@ilayda-cp ilayda-cp deleted the WD-36121-tracking-fix branch April 17, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants