Skip to content

chore: Remove sorting and filtering from remodels table#5680

Merged
steverydz merged 1 commit intomainfrom
WD-36253-remove-sort-and-filtering-from-remodel-table
Apr 24, 2026
Merged

chore: Remove sorting and filtering from remodels table#5680
steverydz merged 1 commit intomainfrom
WD-36253-remove-sort-and-filtering-from-remodel-table

Conversation

@steverydz
Copy link
Copy Markdown
Contributor

@steverydz steverydz commented Apr 23, 2026

Done

Removes sorting and filtering from remodels table as they don't work with the API pagination

How to QA

Testing

  • This PR has tests
  • No testing required (explain why):

Security

  • Security considerations for review (list them):
    • Examples:
    • Access control: users can only access their own data
    • Input: user input is validated and sanitised
    • Sensitive data: secret or private data is not exposed in any way
    • ...
  • This PR has no security considerations (explain why): No user input

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-36253

Screenshots

n/a

UX Approval

  • This PR does not require UX approval
  • This PR does require UX approval (add context):

Copilot AI review requested due to automatic review settings April 23, 2026 12:04
@webteam-app
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes client-side filtering and table sorting from the Publisher “Remodels” table, along with the related state and test coverage.

Changes:

  • Removes remodels filter state/selectors from Jotai state.
  • Simplifies RemodelTable to render unsorted/unfiltered rows and updates the empty state message.
  • Deletes sorting/filter-related tests from the Remodel page/table test suites.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
static/js/publisher/state/remodelsState.ts Drops filter/derived atoms and exports only the base remodels list atom.
static/js/publisher/pages/Remodel/RemodelTable.tsx Removes sortable table configuration and sorting hook usage; updates empty state text.
static/js/publisher/pages/Remodel/Remodel.tsx Removes filter UI and URL param handling; keeps list population from API.
static/js/publisher/pages/Remodel/tests/RemodelTable.test.tsx Removes column-sorting interaction tests.
static/js/publisher/pages/Remodel/tests/Remodel.test.tsx Removes filter visibility tests tied to permissions.

Comment thread static/js/publisher/pages/Remodel/Remodel.tsx
@steverydz steverydz force-pushed the WD-36253-remove-sort-and-filtering-from-remodel-table branch from cccef3b to b4f06aa Compare April 23, 2026 12:34
@steverydz steverydz force-pushed the WD-36253-remove-sort-and-filtering-from-remodel-table branch from b4f06aa to 1736696 Compare April 23, 2026 14:00
@ilayda-cp ilayda-cp self-requested a review April 24, 2026 07:56
@steverydz steverydz merged commit 32ef03d into main Apr 24, 2026
14 checks passed
@steverydz steverydz deleted the WD-36253-remove-sort-and-filtering-from-remodel-table branch April 24, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants