chore: Remove sorting and filtering from remodels table#5680
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes client-side filtering and table sorting from the Publisher “Remodels” table, along with the related state and test coverage.
Changes:
- Removes remodels filter state/selectors from Jotai state.
- Simplifies
RemodelTableto render unsorted/unfiltered rows and updates the empty state message. - Deletes sorting/filter-related tests from the Remodel page/table test suites.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| static/js/publisher/state/remodelsState.ts | Drops filter/derived atoms and exports only the base remodels list atom. |
| static/js/publisher/pages/Remodel/RemodelTable.tsx | Removes sortable table configuration and sorting hook usage; updates empty state text. |
| static/js/publisher/pages/Remodel/Remodel.tsx | Removes filter UI and URL param handling; keeps list population from API. |
| static/js/publisher/pages/Remodel/tests/RemodelTable.test.tsx | Removes column-sorting interaction tests. |
| static/js/publisher/pages/Remodel/tests/Remodel.test.tsx | Removes filter visibility tests tied to permissions. |
cccef3b to
b4f06aa
Compare
b4f06aa to
1736696
Compare
ilayda-cp
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Removes sorting and filtering from remodels table as they don't work with the API pagination
How to QA
Testing
Security
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-36253
Screenshots
n/a
UX Approval