Skip to content

bug: variable WEB_THEME_DARKENING_ONLY is not recognized #6

@yucehasan

Description

@yucehasan

Plugin version:

1.0.1

Platform(s):
Android

Current behavior:
Gradle build fails because a constant is not recognized

Expected behavior:
It should build

Steps to reproduce:
Try to build the app

Related code:

WebSettingsCompat.setForceDarkStrategy(settings, WebSettingsCompat.WEB_THEME_DARKENING_ONLY);

        if (WebViewFeature.isFeatureSupported(WebViewFeature.FORCE_DARK_STRATEGY)) {
            WebSettingsCompat.setForceDarkStrategy(settings, WebSettingsCompat.WEB_THEME_DARKENING_ONLY);
        }

Other information:
Error log:

            WebSettingsCompat.setForceDarkStrategy(settings, WebSettingsCompat.WEB_THEME_DARKENING_ONLY);
                                                                              ^
  symbol:   variable WEB_THEME_DARKENING_ONLY
  location: class WebSettingsCompat

I think it might be replaced with

        if (WebViewFeature.isFeatureSupported(WebViewFeature.FORCE_DARK_STRATEGY)) {
            WebSettingsCompat.setForceDarkStrategy(settings, WebSettingsCompat.DARK_STRATEGY_WEB_THEME_DARKENING_ONLY);
        }

Capacitor doctor:

💊   Capacitor Doctor  💊 

Latest Dependencies:

  @capacitor/cli: 4.3.0
  @capacitor/core: 4.3.0
  @capacitor/android: 4.3.0
  @capacitor/ios: 4.3.0

Installed Dependencies:

  @capacitor/cli: 4.0.1
  @capacitor/android: 4.0.0
  @capacitor/core: 4.0.0
  @capacitor/ios: 4.0.1

[success] iOS looking great! 👌
[success] Android looking great! 👌

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions