feat(functions): Add regionOrCustomDomain option to useEmulator.#766
Merged
Conversation
17 tasks
robingenz
requested changes
Dec 5, 2024
Contributor
Author
|
Hi @robingenz, Thank you for review! |
robingenz
reviewed
Dec 6, 2024
robingenz
reviewed
Dec 6, 2024
robingenz
requested changes
Dec 6, 2024
robingenz
left a comment
Member
There was a problem hiding this comment.
Please run npm run fmt to format the code.
Member
|
@dimer47 Let me know if you have any questions! |
* fix useEmulator for specific region Introduced a new property `regionOrCustomDomain` to the `UseEmulatorOptions` interface to enable specifying either a region or a custom domain for callable Firebase functions. This change facilitates greater flexibility in configuring the functions emulator based on deployment preferences. Updated related documentation to reflect these changes for clarity.
Contributor
Author
|
@robingenz sorry for the delay in getting back, I formatted the code and amended my commit with the fix. |
robingenz
reviewed
Dec 9, 2024
@capacitor-firebase/analytics
@capacitor-firebase/app
@capacitor-firebase/app-check
@capacitor-firebase/authentication
@capacitor-firebase/crashlytics
@capacitor-firebase/firestore
@capacitor-firebase/functions
@capacitor-firebase/messaging
@capacitor-firebase/performance
@capacitor-firebase/remote-config
@capacitor-firebase/storage
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a new property
regionOrCustomDomainto theUseEmulatorOptionsinterface to enable specifying either a region or a custom domain for callable Firebase functions. This change facilitates greater flexibility in configuring the functions emulator based on deployment preferences. Updated related documentation to reflect these changes for clarity.Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset).Close #765