update cntools.sh / 1024 bytes / CIP-6#1907
Open
CardanoSecurity wants to merge 1 commit into
Open
Conversation
cntools: raise main metadata file cap to 1024 bytes when extended field present (CIP-6) CIP-6 raises the 512-byte main metadata file cap to 1024 bytes when the file references extended metadata. Pools with longer descriptions that also include the extended field currently can't register/update through CNTools because the locally-built JSON crosses 512 bytes once the extended URL is appended. - Locally-built file: 1024-byte cap when meta_extended_option is set, 512 otherwise. - Downloaded file: peek for legacy `extended` or CIP-6 ext fields via jq; if any are present, allow 1024 bytes, else keep strict 512. - Bump extended URL length check from 64 to 128 chars to match CIP-6 (extDataUrl is 128 char max) and the main URL check that was already bumped to 128 in this same flow.
Contributor
|
Thanks for the PR and it looks good to me. Just a quick note before I approve the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cntools: raise main metadata file cap to 1024 bytes when extended field present (CIP-6)
CIP-6 raises the 512-byte main metadata file cap to 1024 bytes when the file references extended metadata. Pools with longer descriptions that also include the extended field currently can't register/update through CNTools because the locally-built JSON crosses 512 bytes once the extended URL is appended.
extendedor CIP-6 ext fields via jq; if any are present, allow 1024 bytes, else keep strict 512.Description
Which issue it fixes?