Install links and alert boxes#884
Open
tmorrell wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for workshop-template-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…is used for content
tmorrell
force-pushed
the
install-links
branch
from
0aaa3f3 to
77c2130
Compare
Member
|
The current build of the template site seems to have these images shown correctly, and I've added a different fix for the alert boxes in 57598a7 If things look good your end, I can close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path used for images result in broken links on https://carpentries.github.io/workshop-template/#python-1. Switching to an absolute path solves the issue.
I also changed the scope of the alert box restriction on the template site. Since "alert-warning" boxes have now been used for things that aren't "instructions for people setting up the template", it doesn't make sense to hide them on the template site. See the OneDrive section at https://carpentries.github.io/workshop-template/#python-1 for an example how it's currently broken.