Add TZ56-PLUS#67
Open
medialica wants to merge 6 commits into
Open
Conversation
Owner
|
Thank you for your work, looks good at first sight. Just a question, have you tested the implementation? |
Author
|
Hey,
thank you for your kind reply.
I’m sorry but I don’t know how to do a test. I know it is possible to do myself an Homey App (or a modified one) and try it but I never done something like this before.
Let me know if I need to do something to help your work.
Thank you again,
Paolo Bernardini
… Il giorno 4 gen 2021, alle ore 01:00, R Mengers ***@***.***> ha scritto:
Thank you for your work, looks good at first sight.
Just a question, have you tested the implementation?
As TKB doesn't like following the normal z-wave specifications, it is completely possible that your device doesn't work the same as the implementation you have copied over and adapted.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#67 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASKZ55F4ZQJ5XSTFH2R25K3SYEALRANCNFSM4VSCRENQ>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is my very first step with GitHub (and Homey too), so I don't know if I'm doing the right things. The scope of this request is to add model TZ56D PLUS (EU) to your Homey driver. So I've basically duplicated "drivers/TZ36" folder into "drivers/TZ56-PLUS" folder and I've changed the productTypeID and productID (driver.compose.json) and some strings accordingly. Please consider that I'm a noob so feel free to do anything you want. Thank you for your great work!