feat: add docs type for conventional commits#2477
Closed
clayrosenthal wants to merge 1 commit intocdk8s-team:masterfrom
Closed
feat: add docs type for conventional commits#2477clayrosenthal wants to merge 1 commit intocdk8s-team:masterfrom
clayrosenthal wants to merge 1 commit intocdk8s-team:masterfrom
Conversation
Signed-off-by: Clay Rosenthal <clayros@amazon.com>
iliapolo
requested changes
May 7, 2025
Member
iliapolo
left a comment
iliapolo
left a comment
There was a problem hiding this comment.
@clayrosenthal appreciate the PR, but this needs to be done via projen (note that this file generated). We use a common repository for all our projen based config, so it needs to be changed over there and it will then be automatically applied to all our repos.
Let me know if you want to pursue it and I can provide more guidance.
Contributor
Author
|
Opened a PR in the projen repo |
auto-merge was automatically disabled
May 19, 2025 21:27
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2476, allows
docs:type for PRs