fix: resolve #2827 — CDK8s+: Support headless services without ports#3006
Open
tudragon154203 wants to merge 2 commits intocdk8s-team:masterfrom
Conversation
…out ports Fixes cdk8s-team#2827 Signed-off-by: tudragon154203 <76395825+tudragon154203@users.noreply.github.com>
…out ports Fixes cdk8s-team#2827 Signed-off-by: tudragon154203 <76395825+tudragon154203@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: resolve #2827 — CDK8s+: Support headless services without ports
Problem
Severity:
High| File:packages/cdk8s-plus-XX/src/service.tsThe Service class currently requires at least one port to be configured. However, Kubernetes headless services (clusterIP: "None") used for reverse DNS lookup do not require ports. The validation that throws "A service must be configured with a port" must be relaxed when the service is headless (clusterIP === "None"). Additionally, add a
ClusterIPconstant (e.g.,ClusterIP.NONEor similar) to explicitly represent headless services.Solution
Changes
packages/cdk8s-plus-27/src/service.ts(new)test/cdk8s-plus-XX/test.service.ts(new)Testing
Generated by ContribAI v5.8.1