Fix namespace of js configiration generator#118
Merged
joaquintomas2003 merged 2 commits into0-3-1from Feb 10, 2026
Merged
Conversation
Member
Author
|
We should have a test that actually fully runs the generator, to be able to catch these bugs |
joaquintomas2003
force-pushed
the
fix-js-generator
branch
from
473b5be to
074a323
Compare
santiagorodriguez96
approved these changes
Feb 9, 2026
Collaborator
santiagorodriguez96
left a comment
santiagorodriguez96
left a comment
There was a problem hiding this comment.
Should we update the CHANGELOG?
Collaborator
|
Also I think I would merge this into a different branch that only includes this change – something like What do you think? |
joaquintomas2003
force-pushed
the
fix-js-generator
branch
from
074a323 to
fea4e26
Compare
santiagorodriguez96
approved these changes
Feb 10, 2026
|
|
||
| ### Fixed | ||
|
|
||
| - Fix `install_generator` invoking wrong namespace for `javascript_configuration_generator`. [#118](https://github.com/cedarcode/devise-webauthn/pull/118) [@joaquintomas2003] |
Collaborator
There was a problem hiding this comment.
nit: what do you think about
- Fix `install_generator` invoking missing `devise:webauthn:javascript` task
6e14f8b to
8939a8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
install_generatorinvoking the wrong namespace.Issue raised in #117
Closes #117