Skip to content

Dispatch webauthn:unsupported for browsers missing parseOptionsFromJSON#127

Merged
santiagorodriguez96 merged 3 commits intomasterfrom
sr--handle-new-webauthn-api-unsupported
Mar 4, 2026
Merged

Dispatch webauthn:unsupported for browsers missing parseOptionsFromJSON#127
santiagorodriguez96 merged 3 commits intomasterfrom
sr--handle-new-webauthn-api-unsupported

Conversation

@santiagorodriguez96
Copy link
Copy Markdown
Collaborator

@santiagorodriguez96 santiagorodriguez96 commented Mar 3, 2026

Closes #113.

RenzoMinelli
RenzoMinelli reviewed Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@RenzoMinelli RenzoMinelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we missing a test for this javascript method? Should we add something to test it?

@santiagorodriguez96
Copy link
Copy Markdown
Collaborator Author

santiagorodriguez96 commented Mar 4, 2026

are we missing a test for this javascript method? Should we add something to test it?

I guess we could use system tests for testing that... but IMO falls out of scope of this PR as those test cases doesn't exist yet. Perhaps we can open a separate issue for adding test coverage of handling WebAuthn unsupported?

@santiagorodriguez96 santiagorodriguez96 mentioned this pull request Mar 4, 2026
Open
@santiagorodriguez96
Copy link
Copy Markdown
Collaborator Author

santiagorodriguez96 commented Mar 4, 2026 •
edited
Loading

are we missing a test for this javascript method? Should we add something to test it?

I guess we could use system tests for testing that... but IMO falls out of scope of this PR as those test cases doesn't exist yet. Perhaps we can open a separate issue for adding test coverage of handling WebAuthn unsupported?

@RenzoMinelli I've opened an issue for adding test coverage: #129

@santiagorodriguez96 santiagorodriguez96 merged commit ef58c35 into master Mar 4, 2026
25 checks passed
@santiagorodriguez96 santiagorodriguez96 deleted the sr--handle-new-webauthn-api-unsupported branch March 4, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RenzoMinelli RenzoMinelli RenzoMinelli approved these changes

@nicolastemciuc nicolastemciuc Awaiting requested review from nicolastemciuc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Throw a webauhn:unsupported error if browser does not support native functions for parsing options to JSON

2 participants

@santiagorodriguez96 @RenzoMinelli
⚡