redis.connection.ConnectionPool API change: get_connection does not accept arguments

[woutdenolf]

Closes #2293

[sevdog]

Why using packaging when redis-py defines VERSION and __version__ at package level?

https://github.com/redis/redis-py/blob/5977e387760cb30936629919d5dc76a27652c790/redis/__init__.py#L48-L49

And at least from v4.5.2 (which is the current minimum target of kombu):

https://github.com/redis/redis-py/blob/318b114f4da9846a2a7c150e1fb702e9bebd9fdf/redis/__init__.py#L50-L59

This could have just been

_REDIS_GET_CONNECTION_WITHOUT_ARGS = redis.VERSION >= (5, 3)

No extra imports required, no extra dependencies.

[woutdenolf]

The motivation for this is described in this comment: #2294 (comment).

[auvipy]

Why using packaging when redis-py defines VERSION and __version__ at package level?

https://github.com/redis/redis-py/blob/5977e387760cb30936629919d5dc76a27652c790/redis/__init__.py#L48-L49

And at least from v4.5.2 (which is the current minimum target of kombu):

https://github.com/redis/redis-py/blob/318b114f4da9846a2a7c150e1fb702e9bebd9fdf/redis/__init__.py#L50-L59

This could have just been

_REDIS_GET_CONNECTION_WITHOUT_ARGS = redis.VERSION >= (5, 3)

No extra imports required, no extra dependencies.

I agree with the reasoning of @sevdog here

[sevdog]

The motivation for this is described in this comment: #2294 (comment).

That would be a good solution when you have a generic dependency and you must handle it in a generic way. Since the dependency here is known and because this aims to fix a derecation warning adding a new dependency and two imports to address this looks a bit of overengineering.

[auvipy]

I will open a pr to fix this