fix: allow empty public keys#371
Merged
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/v0.46.x-celestia #371 +/- ##
============================================================
- Coverage 65.55% 65.54% -0.01%
============================================================
Files 666 666
Lines 71180 71213 +33
============================================================
+ Hits 46661 46680 +19
- Misses 21936 21945 +9
- Partials 2583 2588 +5
|
This was referenced Jan 17, 2024
Closed
rootulp
reviewed
Jan 18, 2024
evan-forbes
approved these changes
Jan 19, 2024
ninabarbakadze
approved these changes
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Empty public keys would throw an error when calling
SetSignatures. Public keys are optional and only needed in the first transaction to set it in state.This should not break consensus and thus is okay as a minor release
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change