Move state transformation from proxy wrapper to proxy-state-tree hook#641
Merged
henri-hulski merged 1 commit intonextfrom Dec 5, 2025
Merged
Move state transformation from proxy wrapper to proxy-state-tree hook#641henri-hulski merged 1 commit intonextfrom
henri-hulski merged 1 commit intonextfrom
Conversation
… hook Moves state transformation logic from an external proxy wrapper into proxy-state-tree's internal proxy mechanism. ISSUES CLOSED: #638
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #638 by reimplementing namespace scoping at a lower level within
proxy-state-tree instead of wrapping state with an additional proxy layer.
The initial implementation used createScopedProxy which worked for actions
and effects but caused incorrect nested state mutations due to adding an
extra proxy layer on top of proxy-state-tree's existing proxies.
Changes in proxy-state-tree:
Changes in Overmind:
This approach eliminates the extra proxy layer while maintaining namespace
scoping functionality, allowing state.user.status mutations to work correctly
in namespaced modules.