Skip to content

chore: remove "fixdeps" script, update node types version#645

Merged
henri-hulski merged 12 commits intocerebral:nextfrom
ericsorenson:next
Mar 10, 2026
Merged

chore: remove "fixdeps" script, update node types version#645
henri-hulski merged 12 commits intocerebral:nextfrom
ericsorenson:next

Conversation

@ericsorenson
Copy link
Copy Markdown
Collaborator

@ericsorenson ericsorenson commented Mar 9, 2026

No description provided.

Update all safe patch and minor version bumps across root package.json
and packages/overmind-graphql. Skips major version bumps for electron,
emotion, svelte, eslint v10, graphql-request v7, is-plain-obj v4, and
tsdown due to breaking changes.
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Mar 9, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@henri-hulski
Copy link
Copy Markdown
Member

henri-hulski commented Mar 9, 2026

Hi Eric,
Thanks for your PR.
Seems that the lock file is not up to date.
Also run npm run checkdeps to make sure the dependencies are in sync. If you see errors you need to adjust the versions in the related packages package.json.
BTW don't use npm run fixdeps, it's broken. Actually you can remove it if you want.

@ericsorenson
Copy link
Copy Markdown
Collaborator Author

@henri-hulski sorry about that, I've fixed it! Are you interested in more PRs to update other dependencies? I am interested in helping!

@henri-hulski
Copy link
Copy Markdown
Member

npm error `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.

I still get this error when running the gh actions.

Pin babel-plugin-macros@^3.1.0 as a direct devDependency to resolve
version conflict where jest-circus/dedent requires ^3.1.0 but emotion
only provides 2.8.0. Follows the same pattern as the cosmiconfig fix.
@henri-hulski
Copy link
Copy Markdown
Member

@ericsorenson You can try to update other packages.
I was not able to update emotion, graphql-request and is-plain-obj, I think we should leave them as they are.
Tsdown should not be a problem.
You can update and adjust eslint if all dependencies already support eslint 10. Last time I checked in a different project I was not able to update yet.
I don't remember if electron had an issue, but you can try.
If you want to update Svelte, I think you need to update the whole @overmind/svelte package as the newer versions are not compatible. If you use Svelte you can try. I don't use it, so I prefer not to touch it.

@henri-hulski
Copy link
Copy Markdown
Member

This error is solved. Now I get
** run checkDependencies: execution FAILED **

Did you run it?

@henri-hulski
Copy link
Copy Markdown
Member

henri-hulski commented Mar 9, 2026

In the root package.json you need to avoid the ^ before the version for deps which are also used in packages. But in the package package.json you need to add it. It's a bit strange, I think it should make the actual package more flexible but have a testable setup in the monorepo.

@ericsorenson
Copy link
Copy Markdown
Collaborator Author

Thanks @henri-hulski I'm going to close this for now and get it passing in my fork so that I can stop bothering you!

@ericsorenson ericsorenson reopened this Mar 10, 2026
@ericsorenson ericsorenson changed the title chore: update dependencies to latest patch/minor versions chore: remove "fixdeps" script, update node types version Mar 10, 2026
@henri-hulski henri-hulski merged commit b88b250 into cerebral:next Mar 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants