bug fix: pipe/branch operators re-invoke on error instead of propagating it#650
Merged
henri-hulski merged 1 commit intocerebral:nextfrom Mar 17, 2026
Merged
bug fix: pipe/branch operators re-invoke on error instead of propagating it#650henri-hulski merged 1 commit intocerebral:nextfrom
pipe/branch operators re-invoke on error instead of propagating it#650henri-hulski merged 1 commit intocerebral:nextfrom
Conversation
…agating it
he bug was in packages/overmind/src/operators.ts in both pipe (line 105) and branch (line 217). The catch blocks were re-invoking the same operator that just
threw:
// Before (bug): re-invokes the throwing operator → infinite recursion
catch (operatorError) {
operatorToRun(operatorErr, operatorContext, run, final)
}
// After (fix): propagates the error to the next operator in the chain
catch (operatorError) {
run(operatorError, operatorContext)
}
By calling run(operatorError, operatorContext), the error is passed forward through the operator chain where it can be handled by catchError or tryCatch —
matching how createOperator and createMutationOperator already handle errors internally.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug was in packages/overmind/src/operators.ts in both pipe (line 105) and branch (line 217). The catch blocks were re-invoking the same operator that just
threw:
// Before (bug): re-invokes the throwing operator → infinite recursion
catch (operatorError) {
operatorToRun(operatorErr, operatorContext, run, final)
}
// After (fix): propagates the error to the next operator in the chain
catch (operatorError) {
run(operatorError, operatorContext)
}
By calling run(operatorError, operatorContext), the error is passed forward through the operator chain where it can be handled by catchError or tryCatch —
matching how createOperator and createMutationOperator already handle errors internally.