Fix Maximum call stack size exception in computeLabelSizes#7883
Merged
kurkle merged 1 commit intochartjs:2.9from Oct 17, 2020
Merged
Fix Maximum call stack size exception in computeLabelSizes#7883kurkle merged 1 commit intochartjs:2.9from
kurkle merged 1 commit intochartjs:2.9from
Conversation
Contributor
Author
|
The same change could be made in the master branch, but I wasn't able to reproduce #7881. Something seems to have changed regarding the |
etimberg
reviewed
Oct 14, 2020
etimberg
approved these changes
Oct 14, 2020
kurkle
approved these changes
Oct 17, 2020
Member
kurkle
left a comment
kurkle
left a comment
There was a problem hiding this comment.
Maybe we should do this for v3 too.
Member
|
Would be a good idea to take this into v3 as well |
kurkle
changed the title
Contributor
Author
|
I should be able to submit a PR for v3 soon. I figured I'd wait for this one to be approved first. |
Member
|
thanks @silentmatt |
This was referenced Aug 16, 2024
This was referenced Sep 8, 2024
This was referenced Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling Math.max with a large number of values was throwing an exception.
Tracking the current largest width and height as the widths and heights are
built up should be faster and avoids the exception.