Skip to content

bug(websocket): memory leak when option 'ws:true' is used.#114

Merged
chimurai merged 1 commit intomasterfrom
ws-memory-leak
Sep 28, 2016
Merged

bug(websocket): memory leak when option 'ws:true' is used.#114
chimurai merged 1 commit intomasterfrom
ws-memory-leak

Conversation

@chimurai
Copy link
Copy Markdown
Owner

fixes #113

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 26, 2016

Coverage Status

Coverage increased (+0.04%) to 96.914% when pulling e4f8da7 on ws-memory-leak into 4db1bfa on master.

@chimurai chimurai changed the title bug(websocket): fix memory leak when option 'ws:true' is used. bug(websocket): memory leak when option 'ws:true' is used. Sep 26, 2016
Copy link
Copy Markdown

@julbra julbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chimurai This fixes the leak in my tests. Thank you!

@chimurai chimurai merged commit 2bf1f93 into master Sep 28, 2016
@chimurai chimurai deleted the ws-memory-leak branch September 28, 2016 22:10
@chimurai
Copy link
Copy Markdown
Owner Author

Fix is shipped in v0.17.2

Thanks for reporting the issue. Appreciate all the effort @julbra !

@julbra
Copy link
Copy Markdown

julbra commented Sep 30, 2016

Excellent, glad to be of help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory leak (ws: true)

3 participants