Keeping track of Process status as well as result#134
Keeping track of Process status as well as result#134ashishtilara wants to merge 1 commit intochrisboulton:masterfrom ashishtilara:master
Conversation
ashishtilara
commented
Sep 10, 2013
- if the "Perform()" function returns result, store it along with process status
- return process status+result in Resque_Job_Status->get()
- allow user to delete the status from redis
- allow user to query result of the job
- if the "Perform()" function returns result, store it along with process status - return process status+result in Resque_Job_Status->get() - allow user to delete the status from redis - allow user to query result of the job
|
Sorry for the delay - meant to chime in sooner. Upon further research, I discovered that part of my previous advice (in PR #132) was incorrect - specifically, this change doesn't affect the Resque Web interface one whit. Apparently, job status (as well as job stats, though that's another story altogether) isn't one of the things Ruby Resque tracks. So that argument against accepting and merging this PR is invalid. In fact, this kind of functionality is actually available in Ruby Resque 1.8 via the resque-result plugin. So there's precedent for accepting this kind of modification into the project. Especially since PHP-Resque doesn't encourage plugins in the same way the Ruby version does - though it supports them, since it provides the same (or at least a very similar) hook system. Ultimately? One of my projects handles all of this by having a parent class for all jobs that stores results in Redis as part of the |
|
Looks ok 👍 |