Add method to retrieve all the items of a list#284
Open
varvar wants to merge 1 commit intochrisboulton:masterfrom
Open
Add method to retrieve all the items of a list#284varvar wants to merge 1 commit intochrisboulton:masterfrom
varvar wants to merge 1 commit intochrisboulton:masterfrom
Conversation
Contributor
|
I'd do a couple of things to this before expecting a merge. First, most of the Resque methods have more descriptive names than the underlying Redis command, so I'd change the method name to something else that reflects its purpose rather than its internals. Second, I'd make the second two arguments optional, and default them to retrieve the full list. This will increase the added value of such a function. |
Contributor
|
Other than that, though (and the coding style - spaces between function arguments, please), it looks good here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HI, I've added a method which can retrieve all the items of a list. For example : all failed queues