chore: upstream/downstream flow test (sync-check + lint fix)#2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a downstream “sync readiness” guard to help downstream repos keep local customizations within safe boundaries before pulling upstream DevHolm changes, and applies small lint/formatting fixes to keep CI passing.
Changes:
- Add a new
pnpm devholm sync:checkCLI command that reports whether modified files stay within downstream-safe boundaries. - Document the new pre-flight upgrade step in
docs/upgrading.md. - Apply minor lint/formatting cleanups (including a variable rename for clarity) in server-side extension helpers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/core/lib/extensions.server.ts |
Formatting/lint cleanup and clearer local variable naming in admin page extension loading. |
scripts/devholm-cli.ts |
Adds sync:check command and updates CLI help output. |
docs/upgrading.md |
Adds an upgrade pre-flight step and improves the “safe to customize” table formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+409
to
+413
| const changedFiles = statusOutput | ||
| .split('\n') | ||
| .map((line) => line.trim()) | ||
| .filter(Boolean) | ||
| .map((line) => line.replace(/^..\s+/, '').replace(/^"|"$/g, '')); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR validates the upstream side of the new downstream sync flow.
Includes:
Purpose: ensure downstream repos can pull this cleanly and CI passes.