moved #75 fix to main repo#106
Open
notreallyryan wants to merge 2 commits intodevelopmentfrom
Open
Conversation
Member
|
Can you merge development and push? I just pushed some snapshot tests into the CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out I left the #75 fix that I made on my fork - it must have gotten lost when I moved to the main repo. As I'm re-purposing my fork to experiment with the libavoid library, I've moved the branch here.
Not sure how pythonic the nested function is, but this fixes the " " values and extra whitespace edge case for every text entry field. The exception is the
null_valsfield, to account for the possibility of " " being the null value.