A pull request for #242 (greedy decoding and vectorization in attention.py)#257
Merged
neubig merged 4 commits intoclab:masterfrom Jan 20, 2017
Merged
A pull request for #242 (greedy decoding and vectorization in attention.py)#257neubig merged 4 commits intoclab:masterfrom
neubig merged 4 commits intoclab:masterfrom
Conversation
Contributor
|
This is great, but |
Contributor
Author
|
Oh, you are right. Here is the new version. |
Contributor
|
Looks good! Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses both issues. I've kept comments with tensor dimensionality in the computation of the attention weights, just tell me if I you'd prefer them removed.