fix on stream close too early#55
Merged
menzowindhouwer merged 2 commits intoclarin-eric:masterfrom Apr 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By reading from cached xml file instead of reading it from remote source each time, it saves time and eliminates the possibility of having remote source closed too early, which will result in an error and discontinue with the transformation.
The problem comes from the particular way of using docker to load the local jar to for testing. It loads old version of jar even built successfully using mvn and docker.
Both jdk 11 and 21 works well with the fix. This is tested with the official jdk 11 java base image and jdk 21 java based image (custom build with official java base).
Next step is to run the harvester container on an actual harvest config.