Conversation
- add 'bin/console' exec (not use 'bundle console') - git ignore vcr cassettes (have your own local cassettes) - remove coveralls for tests
Contributor
|
The captions addition looks good to me. Does the removal of cassettes mean that tests will now only run whenever someone has set the following env variables? And they will always test against live data? Did you test running the suite from scratch to see if that works? |
Collaborator
Author
|
Yes, I ran test with those env variables and it passed. As you may know I couldn't run yt (captions) $ rspec
Run options: exclude {:slow=>true}
Randomized with seed 53975
....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
Finished in 1 minute 29.11 seconds (files took 0.75296 seconds to load)
724 examples, 0 failures
Randomized with seed 53975
Coverage report generated for RSpec to /Users/kangkyu/code/yt/coverage. 5678 / 6039 LOC (94.02%) covered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this change, we can do something like this
closes #413