Skip to content

Fix simulator device selection for UI tests#384

Merged
seanperez29 merged 1 commit intomainfrom
sean/Fix-simulator-device-selection
Mar 23, 2026
Merged

Fix simulator device selection for UI tests#384
seanperez29 merged 1 commit intomainfrom
sean/Fix-simulator-device-selection

Conversation

@seanperez29
Copy link
Copy Markdown
Collaborator

@seanperez29 seanperez29 commented Mar 23, 2026

Use xcrun simctl list to find available simulators instead of matching against a hardcoded list of device names. This is more reliable as it directly queries booted/available devices and uses the simulator UUID for precise targeting.

Summary by CodeRabbit

  • Chores
    • Enhanced iOS simulator selection logic in development build tools to improve test infrastructure reliability.

Use `xcrun simctl list` to find available simulators instead
of matching against a hardcoded list of device names. This is
more reliable as it directly queries booted/available devices
and uses the simulator UUID for precise targeting.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 12c6970f-5aaf-4a99-9f0f-0bd5100e903c

📥 Commits

Reviewing files that changed from the base of the PR and between 3433df3 and 3e13df9.

📒 Files selected for processing (1)
  • Makefile

Walkthrough

The test-ui Makefile target's iOS simulator detection logic was refactored. When IOS_SIMULATOR_DESTINATION is unset, the method for finding and selecting an available simulator changed from using xcodebuild -showdestinations with name-based matching to using xcrun simctl list devices available with UUID-based identification.

Changes

Cohort / File(s) Summary
iOS Simulator Detection
Makefile
Updated test-ui target to use xcrun simctl for device discovery instead of xcodebuild -showdestinations; switched from name-based destination selection to UUID-based platform identifier.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A makefile change, swift and clean,
Where simulators are found by machine,
No more names in the shell we chase,
Just UUIDs running the race—
The rabbit hops with delight! 🏃‍♂️✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing simulator device selection for UI tests by replacing hardcoded device name matching with dynamic simulator querying via xcrun simctl.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sean/Fix-simulator-device-selection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seanperez29 seanperez29 merged commit d632beb into main Mar 23, 2026
11 checks passed
@seanperez29 seanperez29 deleted the sean/Fix-simulator-device-selection branch March 23, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant