Skip to content

chore: explicitly set compilation kind#184

Merged
16bit-ykiko merged 7 commits intoclice-io:mainfrom
Guo-Shiyu:chore/explicit-collect-decl
Aug 23, 2025
Merged

chore: explicitly set compilation kind#184
16bit-ykiko merged 7 commits intoclice-io:mainfrom
Guo-Shiyu:chore/explicit-collect-decl

Conversation

@Guo-Shiyu
Copy link
Copy Markdown
Contributor

No description provided.

@Guo-Shiyu
Copy link
Copy Markdown
Contributor Author

Try to fix up a problem in src/Compiler/Compilation.cpp:

        /// FIXME: We may want to use a more explicit way to judge this.
        need_collect = instance.getFrontendOpts().OutputFile.empty();

But I'm not sure if this is the appropriate way to pass need_collect parameters. 🤔

@Guo-Shiyu
Copy link
Copy Markdown
Contributor Author

@cursor revieeeeeew!

@cursor
Copy link
Copy Markdown

cursor bot commented Aug 18, 2025

Unable to authenticate your request. Please make sure to connect your GitHub account to Cursor. Go to Cursor

@16bit-ykiko
Copy link
Copy Markdown
Member

@cursor review!

cursor[bot]

This comment was marked as outdated.

Comment thread src/Compiler/Compilation.cpp Outdated
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@16bit-ykiko 16bit-ykiko changed the title Chore: explicitly collect top level declarations during compilation. Chore: explicitly set compilation kind Aug 23, 2025
@16bit-ykiko 16bit-ykiko merged commit cbb210c into clice-io:main Aug 23, 2025
10 checks passed
@Guo-Shiyu Guo-Shiyu deleted the chore/explicit-collect-decl branch August 24, 2025 13:04
@16bit-ykiko 16bit-ykiko changed the title Chore: explicitly set compilation kind chore: explicitly set compilation kind Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants