Skip to content

Refactor/remove redundant ast filters #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Perdixky wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −23
Open

Refactor/remove redundant ast filters #427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 2 additions & 23 deletions src/semantic/filtered_ast_visitor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ class FilteredASTVisitor : public clang::RecursiveASTVisitor<Derived> {
return true;
}

/// Clang doesn't visit implicit declarations and
/// implicit template instantiations by default.
if(llvm::isa<clang::TranslationUnitDecl>(decl)) {
if(interested_only) {
for(auto top: unit.top_level_decls()) {
Expand All @@ -46,29 +48,6 @@ class FilteredASTVisitor : public clang::RecursiveASTVisitor<Derived> {
return Base::TraverseDecl(decl);
}

if(decl->isImplicit()) {
return true;
}

/// We don't want to visit implicit instantiation.
if(auto SD = llvm::dyn_cast<clang::ClassTemplateSpecializationDecl>(decl)) {
if(SD->getSpecializationKind() == clang::TSK_ImplicitInstantiation) {
return true;
}
}

if(auto SD = llvm::dyn_cast<clang::FunctionDecl>(decl)) {
if(SD->getTemplateSpecializationKind() == clang::TSK_ImplicitInstantiation) {
return true;
}
}

if(auto SD = llvm::dyn_cast<clang::VarTemplateSpecializationDecl>(decl)) {
if(SD->getSpecializationKind() == clang::TSK_ImplicitInstantiation) {
return true;
}
}

if constexpr(requires { getDerived().on_traverse_decl(decl, &Base::TraverseDecl); }) {
return getDerived().on_traverse_decl(decl, &Base::TraverseDecl);
} else {
Expand Down
Loading
⚡