cross namespace network traffic allow plugin #1399
Merged
devdattakulkarni merged 11 commits intocloud-ark:masterfrom Mar 9, 2025
Merged
cross namespace network traffic allow plugin #1399devdattakulkarni merged 11 commits intocloud-ark:masterfrom
devdattakulkarni merged 11 commits intocloud-ark:masterfrom
Conversation
Contributor
SuyogShinde942
commented
Feb 24, 2025
SuyogShinde942
commented
- Implemented cross namespace allow/ deny network traffic plugin
- Updated the readme for implementation of allow and deny namespace traffic.
| deny_namespace in expr.get("values", []) | ||
| for expr in expressions | ||
| ) | ||
| if not remove_entry: |
Contributor
There was a problem hiding this comment.
This is a bit involved logic. Let's test it with three namespaces (hs1, hs2, hs3). Start with allowing network traffic between and . This should lead to the Network policy of hs1 to contain two entries [hs2, hs3]. Then deny the network traffic between hs1 and hs3. If the implementation is correct, the NetworkPolicy object for hs1 should only hold [hs2].
Contributor
Author
There was a problem hiding this comment.
This is already tested at my end
Contributor
|
@SuyogShinde942 I have added some comments. |
Contributor
|
@SuyogShinde942 I have one more suggestion related to documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.