Add status of signing and filtering for everybody#397
Open
kroeckx wants to merge 1 commit intocloudflare:masterfrom
Open
Add status of signing and filtering for everybody#397kroeckx wants to merge 1 commit intocloudflare:masterfrom
kroeckx wants to merge 1 commit intocloudflare:masterfrom
Conversation
The signing is based on what https://rpki.cloudflare.com/?view=bgp returns. It's probably not ideal, but it's the best I know. I have used: < 10% valid signatures: not signing > 90% valid signatures: signing otherwise: partial signing
Author
|
Do you intend to merge this? It now of course contains a merge conflict since you've merged something. I don't intend to fix the merge conflict unless you want to merge this. |
Contributor
|
@kroeckx Yes we can merge this. Please follow-up with conflicts and we'll proceed. |
digizeph
added
the
status: pending response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signing is based on what https://rpki.cloudflare.com/?view=bgp
returns. It's probably not ideal, but it's the best I know.
I have used:
< 10% valid signatures: not signing