Disable rules from eslint-plugin-node that TS handles#160
Merged
Conversation
🦋 Changeset is good to goLatest commit: c5bd7d0 We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
tylersticka
approved these changes
Sep 15, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working through changes necessary for this PR and I noticed that these two linting rules were causing problems.
The problems happen in scenarios like this:
If the
afile is a.tsfile, then the code is not actually a problem, but thenode/no-missing-importandnode/no-missing-requirerules flag it as a problem, since they don't recognize.tsfiles. It is possible to configure those rules to support.tsfiles, but it is easier (and faster) to just rely on the typescript type checker to tell us if we import something that doesn't exist.