Revert changes to the no-use-before-define rule #396
Merged
Paul-Hebert merged 3 commits intomainfrom Jul 5, 2022
Merged
Conversation
added 2 commits
July 1, 2022 15:17
🦋 Changeset detectedLatest commit: 94d6926 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
I added back in one fixture file that I deleted when I made my previous change, but there were new lint issues in it from other changes we made. So I deleted it again. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts the previous change to the to
no-use-before-definerule since it was more heavy-handed than expected.I used
git revertto commit the PR commit and then created a new changeset. There were some conflicts when reverting the changes togenerate-changeset. I ended up just backing out those changes since the changes I was reverting were minor and totally fine.Let me know if there's another way you'd prefer I handle this.