Merged
Conversation
Paul-Hebert
reviewed
Jul 16, 2021
Paul-Hebert
approved these changes
Jul 16, 2021
Contributor
Paul-Hebert
left a comment
There was a problem hiding this comment.
This is a killer feature @calebeby !
I'm still wrapping my head around this codebase, but these changes seem reasonable 👍 One nitpick about an error message inline.
gerardo-rodriguez
approved these changes
Jul 20, 2021
Member
gerardo-rodriguez
left a comment
There was a problem hiding this comment.
Super cool feature, great work, @calebeby!
I'm in the same boat as @Paul-Hebert where I don't understand every line of code fully but overall, the code looks good! Pending the suggestion from Paul, I approve!
Member
Author
|
Thanks for the reviews @Paul-Hebert and @gerardo-rodriguez! Do you mind taking a look at the README changes that I just pushed as well? |
Paul-Hebert
reviewed
Jul 20, 2021
Paul-Hebert
reviewed
Jul 20, 2021
Contributor
|
@calebeby the README info looks good! I left a couple questions inline. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140
The code is all ready for review. I didn't update the README yet.
This makes it possible to configure the module server in each test. You could inject additional rollup plugins, etc. An example of this is to add a plugin to load Vue SFC's:
There is also a
configureDefaultsfunction exported by pleasantest, so you don't have to set the options for each test individually:There is also an internal change: File
ids (used by the rollup plugins) are now absolute paths once they are resolved. This was changed to match Rollup's default behavior, and it fixed a compatibility issue with rollup-plugin-vue. So the ids start out as url's, which are relative to the project root, then they get converted to absolute paths, and run through all the plugins, and at the very end before the module is served they get converted back into paths that are relative to the project root.