Allow functions to be passed to runJS#234
Merged
gerardo-rodriguez merged 3 commits intomainfrom Sep 1, 2021
Merged
Conversation
Member
|
@gerardo-rodriguez Can you add a changeset? |
Paul-Hebert
approved these changes
Sep 1, 2021
Contributor
Paul-Hebert
left a comment
Paul-Hebert
left a comment
There was a problem hiding this comment.
Looks good, nice work! 🦖
(I started typing :tada and then the t-rex popped up, so you get a 🦖 instead)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature was co-written with @calebeby. This allows functions to be passed to
runJS.See the new test to help understand the intent.
Closes #47