Conversation
calebeby
changed the title
user.selectOptions()
spaceninja
approved these changes
May 13, 2021
Member
spaceninja
left a comment
spaceninja
left a comment
There was a problem hiding this comment.
I'm not familiar enough with this code to be 100% confident in approving it, but the changes look reasonable.
gerardo-rodriguez
approved these changes
May 13, 2021
Member
gerardo-rodriguez
left a comment
gerardo-rodriguez
left a comment
There was a problem hiding this comment.
Great work, @calebeby! 🎉
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplements https://github.com/testing-library/user-event#selectoptionselement-values using Puppeteer methods, and adds it to the
userobject