Skip to content

fix: select nodepool id when describe cluster attach scripts#208

Merged
jwcesign merged 1 commit intocloudpilot-ai:mainfrom
Vacant2333:select-nodepool-id-when-describe-cluster-attach-scriptes
Mar 24, 2025
Merged

fix: select nodepool id when describe cluster attach scripts#208
jwcesign merged 1 commit intocloudpilot-ai:mainfrom
Vacant2333:select-nodepool-id-when-describe-cluster-attach-scriptes

Conversation

@Vacant2333
Copy link
Copy Markdown
Contributor

@Vacant2333 Vacant2333 commented Mar 24, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

We encountered a situation where the DescribeClusterAttachScriptsRequest will use the default nodepool when the NodepoolID is not provided. However, in some cases, the default nodepool may have been deleted, but DescribeClusterAttachScriptsRequest will still use the CRI configuration of the default nodepool. In an ACK cluster with version 1.24, if the default nodepool was originally created with Docker Runtime but was later deleted and replaced with a new nodepool using Containerd Runtime, this could cause nodes to fail to register to the cluster. This is because Docker Runtime only supports clusters of version 1.22 and below now.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

To call `DescribeClusterAttachScriptsRequest`, Karpenter need to provide the NodePoolID now, preferably selecting the default NodePool. If you are using Karpenter deployed with minimal permissions after account transfer, you need to grant your RAM User the permission cs:DescribeClusterNodePools. This will resolve the issue where nodes created by older clusters may fail to register with the cluster in some cases.

@Vacant2333 Vacant2333 force-pushed the select-nodepool-id-when-describe-cluster-attach-scriptes branch from 7fdb848 to 5f51082 Compare March 24, 2025 07:01
@Vacant2333 Vacant2333 marked this pull request as ready for review March 24, 2025 07:03
@Vacant2333 Vacant2333 requested a review from jwcesign March 24, 2025 07:03
Signed-off-by: Vacant2333 <vacant2333@gmail.com>
@Vacant2333 Vacant2333 force-pushed the select-nodepool-id-when-describe-cluster-attach-scriptes branch from 5f51082 to eb3c38e Compare March 24, 2025 07:12
Copy link
Copy Markdown
Contributor

@jwcesign jwcesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jwcesign jwcesign merged commit 0a6fcfe into cloudpilot-ai:main Mar 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants