fix: select nodepool id when describe cluster attach scripts#208
Merged
jwcesign merged 1 commit intocloudpilot-ai:mainfrom Mar 24, 2025
Conversation
7fdb848 to
5f51082
Compare
Signed-off-by: Vacant2333 <vacant2333@gmail.com>
5f51082 to
eb3c38e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We encountered a situation where the
DescribeClusterAttachScriptsRequestwill use the default nodepool when the NodepoolID is not provided. However, in some cases, the default nodepool may have been deleted, butDescribeClusterAttachScriptsRequestwill still use the CRI configuration of the default nodepool. In an ACK cluster with version 1.24, if the default nodepool was originally created with Docker Runtime but was later deleted and replaced with a new nodepool using Containerd Runtime, this could cause nodes to fail to register to the cluster. This is because Docker Runtime only supports clusters of version 1.22 and below now.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?