Skip to content

Version updates to Ng 21 plus dependencies#661

Merged
sei-tspencer merged 42 commits intomainfrom
version_updates
Feb 24, 2026
Merged

Version updates to Ng 21 plus dependencies#661
sei-tspencer merged 42 commits intomainfrom
version_updates

Conversation

@sei-dupdyke
Copy link
Copy Markdown
Contributor

No description provided.

@sei-dupdyke sei-dupdyke requested a review from a team as a code owner January 23, 2026 18:25
@sei-dupdyke sei-dupdyke marked this pull request as draft January 26, 2026 15:09
@sei-dupdyke sei-dupdyke reopened this Jan 26, 2026
@sei-dupdyke sei-dupdyke marked this pull request as ready for review January 26, 2026 16:15
Copy link
Copy Markdown
Contributor

@sei-aschlackman sei-aschlackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything builds and works, but there's a few visual bugs

  1. Everywhere with Material Tables, the table header and the table body have different background colors now, whereas previously they were both #f1f1f2. Examples are the main page list of views and most of the main views in the Admin area. Also in the stepper when editing/creating a view.

  2. On the main page view list, the horizontal row separator lines don't go all the way across.

  3. In the top bar, the text for the User's name is now black in light mode and white in dark mode, but I think it looks bad as black in light mode on the blue bar background. Should probably be white always.

  4. Edit View -> Teams -> Expand a Team. Team Name is way too wide. Also, the team ID Guide is not aligned with the copy button.

  5. Administration -> Application Templates checkboxes are partially hidden.

  6. Administration. The list of sections on the left is centered now instead of left justified. Not sure if thats better or worse. Feels a little wrong, but maybe more in line with the Material style guide, not sure.

  7. Administration. Views button icon is cut off on the top

@sei-dupdyke
Copy link
Copy Markdown
Contributor Author

These have been corrected. Note that I set a default font for the entire project. Wasn't sure if there was a convention for that in other Crucible apps.

@sei-tspencer sei-tspencer merged commit 64c2029 into main Feb 24, 2026
4 checks passed
@sei-tspencer sei-tspencer deleted the version_updates branch February 24, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants