Merged
Conversation
sei-tspencer
approved these changes
Apr 7, 2026
sei-tspencer
added a commit
that referenced
this pull request
Apr 9, 2026
* Improve Player View Edit Form UX and Fix Application Settings (#689) * Simplify application field labels in view edit - Change application field labels to simple titles - Application Name, Application URL, Icon Path, etc. * Improve view edit form labels and file upload UX - Simplify view information field labels to basic titles - Add DEFAULT badge to default team in team list - Add team selection validation for file uploads - Show red warning when no teams selected for files - Change upload button to 'Save Changes and Upload File' - Disable upload button when no teams selected - Allow clearing teams in UI without server errors - Only save to server when at least one team is selected * Fix application settings dropdowns toggling each other - Remove [(value)]="selected" binding from all dropdowns - Each dropdown now only uses [(ngModel)] for its specific property - Fixes issue where changing Embeddable would affect Load in Background - Simplify save methods to avoid change detection errors - Fix NG0100 ExpressionChangedAfterItHasBeenCheckedError * Improve file upload UX to match team section pattern - Restructure upload section as expansion panel (like teams) - Add file icon before filename in panel title - Move 'Add New File' button to always be visible at top - Match team selection layout to existing uploaded files - Change label to 'Teams with Access' - Add validation warning when no teams selected - Position Cancel and Upload buttons at bottom * Convert application template fields to use mat-label - Change from placeholder to mat-label for Name, URL, Icon Path - Consistent with other form fields across the application * labels added (#692) * Chore/auto version update (#694) * chore: configure automatic version updates via reusable workflow Migrate to the cmu-sei/Crucible-Github-Actions docker-build reusable workflow @docker-v1 and add versionMode/versionFiles inputs to enable automatic version bumping on release. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * migrate to cmu-sei/Crucible-Github-Actions/.github/workflows/docker-build.yaml@docker-v1.1.2 --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * Use v1 tag for docker-build action (#695) * point to 0.6.0 * lock file --------- Co-authored-by: Adam Welle <arwelle@cert.org> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Jarrett Booz <89405171+sei-jbooz@users.noreply.github.com>
sei-tspencer
added a commit
that referenced
this pull request
Apr 9, 2026
* Add classification header to player.ui * Moved common header bar component outside of router outlet * Added classification header * layout fixes * migrate to application builder * fix dockerfile path * add localNPM configuration * update layout * fix application bar scrolling * fix admin roles scrollbars * Added settings.shared.json to gitignore * Add classification banner 2 (#699) * Improve Player View Edit Form UX and Fix Application Settings (#689) * Simplify application field labels in view edit - Change application field labels to simple titles - Application Name, Application URL, Icon Path, etc. * Improve view edit form labels and file upload UX - Simplify view information field labels to basic titles - Add DEFAULT badge to default team in team list - Add team selection validation for file uploads - Show red warning when no teams selected for files - Change upload button to 'Save Changes and Upload File' - Disable upload button when no teams selected - Allow clearing teams in UI without server errors - Only save to server when at least one team is selected * Fix application settings dropdowns toggling each other - Remove [(value)]="selected" binding from all dropdowns - Each dropdown now only uses [(ngModel)] for its specific property - Fixes issue where changing Embeddable would affect Load in Background - Simplify save methods to avoid change detection errors - Fix NG0100 ExpressionChangedAfterItHasBeenCheckedError * Improve file upload UX to match team section pattern - Restructure upload section as expansion panel (like teams) - Add file icon before filename in panel title - Move 'Add New File' button to always be visible at top - Match team selection layout to existing uploaded files - Change label to 'Teams with Access' - Add validation warning when no teams selected - Position Cancel and Upload buttons at bottom * Convert application template fields to use mat-label - Change from placeholder to mat-label for Name, URL, Icon Path - Consistent with other form fields across the application * labels added (#692) * Chore/auto version update (#694) * chore: configure automatic version updates via reusable workflow Migrate to the cmu-sei/Crucible-Github-Actions docker-build reusable workflow @docker-v1 and add versionMode/versionFiles inputs to enable automatic version bumping on release. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * migrate to cmu-sei/Crucible-Github-Actions/.github/workflows/docker-build.yaml@docker-v1.1.2 --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * Use v1 tag for docker-build action (#695) * point to 0.6.0 * lock file --------- Co-authored-by: Adam Welle <arwelle@cert.org> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Jarrett Booz <89405171+sei-jbooz@users.noreply.github.com> * remove --resources-output-path=assets/fonts --------- Co-authored-by: Robert Kemerer <rkemerer@cert.org> Co-authored-by: Andrew Schlackman <72105194+sei-aschlackman@users.noreply.github.com> Co-authored-by: Tim Spencer <72101647+sei-tspencer@users.noreply.github.com> Co-authored-by: Adam Welle <arwelle@cert.org> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Jarrett Booz <89405171+sei-jbooz@users.noreply.github.com> Co-authored-by: sei-tspencer <trspencer@sei.cmu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.