storage: Don't ignore "edit excuse" when constructing key slot rows#23101
Open
mvollmer wants to merge 1 commit intocockpit-project:mainfrom
Open
storage: Don't ignore "edit excuse" when constructing key slot rows#23101mvollmer wants to merge 1 commit intocockpit-project:mainfrom
mvollmer wants to merge 1 commit intocockpit-project:mainfrom
Conversation
mvollmer
force-pushed
the
storage-no-unknown-clevis-edits
branch
from
db9196d to
efe7d9b
Compare
We would let the user attempt to edit "Unknown type" slots, which would crash. Fixes cockpit-project#23095
mvollmer
force-pushed
the
storage-no-unknown-clevis-edits
branch
from
efe7d9b to
bed4540
Compare
Member
Author
|
testing-farm:fedora-44-x86_64:self failure is hopefully fixed by #23107 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would let the user attempt to edit "Unknown type" slots, which would crash.
Fixes #23095