packagekit: link Red Hat issue references in changelogs#23117
packagekit: link Red Hat issue references in changelogs#23117tarunvashishth wants to merge 2 commits intocockpit-project:mainfrom
Conversation
Venefilyn
left a comment
Venefilyn
left a comment
There was a problem hiding this comment.
Thanks! In short I like it but atm I'm skeptical about how the Jira linking is supposed to work. The RHBZ can be made non-distro specific too
| if (!text || !isRedHatBasedDistribution()) | ||
| return text; | ||
|
|
||
| const issuePattern = /(rhbz|jira)#(\d+)/g; |
There was a problem hiding this comment.
I think we can check for rhbz no matter the distro tbh. I don't think anyone else refers to their trackers as rhbz and it is quite normal to link to in regards to CVEs etc.
However, with Jira I agree that we should only link to it within RHEL-sphere, but is it common to write jira#1234? That feels very strange to me as it doesn't include the namespace at all like RHEL-1234.
Do you have links to where the jira#1234 syntax is used?
There was a problem hiding this comment.
I couldn’t find solid evidence that jira#1234 is being used; most Red Hat references I found are RHEL-1234. Should I drop the Jira part and add something like RHEL-1234?
At some point we change to an object with keys to a list with all the objects in it and looking at ID instead. To make it work during manual testing we need to update the syntax from object to array. Signed-off-by: Freya Gustavsson <freya@venefilyn.se>
2 participants
closes #17748