flatpak: Filter out links from description#23130
Open
Venefilyn wants to merge 1 commit intocockpit-project:mainfrom
Open
flatpak: Filter out links from description#23130Venefilyn wants to merge 1 commit intocockpit-project:mainfrom
Venefilyn wants to merge 1 commit intocockpit-project:mainfrom
Conversation
Within the changelog we cannot have URLs within changelog entries themselves, instead FlatHub needs us to have all links within the URL element itself. As we already have a tag now that includes plaintext links - which we didn't before - we need to filter this out to prevent the changelog to update with data that fails validation. Signed-off-by: Freya Gustavsson <freya@venefilyn.se>
Venefilyn
force-pushed
the
flatpak/description-links
branch
from
1905e4a to
5b174db
Compare
Member
Author
|
@mvollmer with the latest 360.1 release we had plaintext links which broke flathub releases. So with tag now being created with plaintext links easiest thing is to modify the script to filter out links This matches stuff like |
mvollmer
reviewed
Apr 15, 2026
| def element(tag, text=None, children=(), **kwargs): | ||
| tag = ET.Element(tag, kwargs) | ||
| tag.text = text | ||
| tag.text = text if text is None else re.sub(r'\S+http\S+', '', text).strip() |
Member
There was a problem hiding this comment.
So with this, the 360.1 description would come out as
Prevent overmounting also for btrfs subvolumes ()
right? (With the empty parentheses.)
Maybe it is better to manually clean this up in the rare cases that it happens?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within the changelog we cannot have URLs within changelog entries
themselves, instead FlatHub needs us to have all links within the URL
element itself.
As we already have a tag now that includes plaintext links - which we
didn't before - we need to filter this out to prevent the changelog to
update with data that fails validation.
Signed-off-by: Freya Gustavsson freya@venefilyn.se