✨ add macos support for test projects in build configuration#64
Conversation
Greptile SummaryThis PR adds macOS platform detection to
Confidence Score: 5/5Safe to merge — the change is a two-line addition to a build properties file with no runtime logic. The IsMacOS property uses the correct OSX platform string (matching OSPlatform.OSX in the .NET runtime), and the updated condition correctly gates net10.0;net9.0 to Linux or macOS while leaving the Windows net48 path untouched. The CI pipeline already has a test_mac job ready to exercise this path. No logic errors or gaps were found. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[MSBuild evaluates Directory.Build.props] --> B{IsTestProject?}
B -- No --> C[Apply source / tooling / benchmark config]
B -- Yes --> D{Platform detection}
D --> E{IsLinux OR IsMacOS?}
E -- Yes --> F["TargetFrameworks = net10.0;net9.0"]
D --> G{IsWindows?}
G -- Yes --> H["TargetFrameworks = net10.0;net9.0;net48"]
E -- No --> I[No TargetFrameworks override from platform block]
G -- No --> I
F --> J[Common test project settings - IsPackable=false, RunAnalyzers=false, etc.]
H --> J
I --> J
Reviews (1): Last reviewed commit: "✨ add macos support for test projects in..." | Re-trigger Greptile |
This pull request updates the build configuration to improve cross-platform support, specifically adding macOS detection and ensuring test projects target the correct frameworks on both Linux and macOS.
Platform detection improvements:
IsMacOSto detect when the build is running on macOS using MSBuild'sIsOSPlatformmethod.Test project configuration:
TargetFrameworksin test projects to include both Linux and macOS, so test projects now targetnet10.0andnet9.0on either OS.