`CircleCI` orb stuck at "Searching for coverage files..."

[NachoSoto]

Describe the bug
A recent PR has made this get stuck for some reason.
My only guess is that the added symlink is causing that, but it shouldn't be affecting the generated coverage file.

See failure: https://circleci.com/gh/RevenueCat/purchases-ios/100212

[drazisil-codecov]

Hi @NachoSoto

The issue appears to the time taken looking for coverage files in your repo.

After 10 minutes of no output, CircleCI assumes the task has frozen and kills it.

Can you tell me more about the symlink you mention? I'm not able to locate it in the PR, due to not being familiar with swift projects.

[NachoSoto]

The logs print Writing coverage to ./coverage-report-RevenueCat.json, what is it looking for?
It's confusing because it's that PR that broke it in particular, it's working in any other branch.

The specifics for why the PR adds this don't really matter, but I wonder if it's related. You can see in the diff that I added a symlink (ci_scripts/Tests). Is Codecov ending up in an infinite recursion traversing the repo because of it?

Otherwise I don't understand why it's spending 10+ minutes looking for coverage files.

[drazisil-codecov]

@NachoSoto I think you may be correct about the symlink being the cause.

uploader/src/helpers/files.ts

Lines 197 to 220 in d761d30

	export async function getCoverageFiles(
	projectRoot: string,
	coverageFilePatterns: string[],
	): Promise<string[]> {
	const globstar = (pattern: string) => `**/${pattern}`
	return glob(coverageFilePatterns.map((pattern: string) => {
	const parts = []
	if (isNegated(pattern)) {
	parts.push('!')
	parts.push(globstar(pattern.substr(1)))
	} else {
	parts.push(globstar(pattern))
	}
	return parts.join(EMPTY_STRING)
	}), {
	cwd: projectRoot,
	dot: true,
	ignore: getBlocklist(),
	suppressErrors: true,
	})
	}

is the function is if getting stuck in, and far as I can tell from line https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/13586/workflows/df589d01-0206-406d-b0cb-d025895372a4/jobs/100212?invite=true#step-112-30075_67

[drazisil-codecov]

https://www.npmjs.com/package/glob Is the library we are using, and it has an option to follow symlinks, but it doesn't look like we are passing that.

So, per https://github.com/isaacs/node-glob/blob/46ff6531345c8d069418efc73a9ebd43d9f24569/src/processor.ts#L181 it should not follow the link.

Then again, maybe Node.js doesn't see this as a symbolic link. 🤔

How did you create it, @NachoSoto ?

[drazisil-codecov]

Note that I'm able to reproduce this locally, and can confirm the uploader works as expected when ci_scripts/Tests is removed.

I don't know why

[NachoSoto]

How did you create it, @NachoSoto ?

It's a soft link: ln -s

[NachoSoto]

Any updates here?

[NachoSoto]

@drazisil-codecov could you at least suggest some workaround? The symlink is not part of the sources so I'd be happy to tell Codecov to ignore it, I just don't know how.

[NachoSoto]

@drazisil-codecov any updates here?

[NachoSoto]

@drazisil-codecov it's been over a month. Can you at least let me know if there are any plans to address this or should be remove Codecov from our repo?