Skip to content

fix: use posix path#141

Merged
drazisil-codecov merged 2 commits intocodecov:masterfrom
drazisil:use-posix-path
Jun 15, 2021
Merged

fix: use posix path#141
drazisil-codecov merged 2 commits intocodecov:masterfrom
drazisil:use-posix-path

Conversation

@drazisil
Copy link
Copy Markdown
Contributor

This changes path to use path.posix per https://nodejs.org/dist/latest-v14.x/docs/api/path.html#path_windows_vs_posix

Thanks @eddiemoore !

This also runs tests on Windows prior to building.

@drazisil drazisil requested a review from a team as a code owner June 15, 2021 16:39
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 15, 2021

Codecov Report

Merging #141 (0f6f601) into master (ed0359b) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   91.57%   91.39%   -0.19%     
==========================================
  Files          30       15      -15     
  Lines        1092      546     -546     
  Branches      210      105     -105     
==========================================
- Hits         1000      499     -501     
+ Misses         40       20      -20     
+ Partials       52       27      -25     
Flag Coverage Δ
alpine 91.39% <100.00%> (-0.19%) ⬇️
linux 91.39% <100.00%> (-0.19%) ⬇️
linux-without-git ∅ <ø> (∅)
macos 91.39% <100.00%> (-0.19%) ⬇️
macos-without-git ∅ <ø> (∅)
windows 90.84% <100.00%> (-0.74%) ⬇️
windows-without-git ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helpers/files.js 92.85% <100.00%> (ø)
src/ci_providers/provider_circleci.js 90.32% <0.00%> (-3.23%) ⬇️
...ci/project/src/ci_providers/provider_appveyorci.js
...roject/src/ci_providers/provider_azurepipelines.js
...project/src/ci_providers/provider_githubactions.js
C:/Users/circleci/project/src/helpers/git.js
...leci/project/src/ci_providers/provider_circleci.js
...:/Users/circleci/project/src/ci_providers/index.js
...ircleci/project/src/ci_providers/provider_local.js
C:/Users/circleci/project/src/helpers/logger.js
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed0359b...0f6f601. Read the comment docs.

@drazisil
Copy link
Copy Markdown
Contributor Author

Looks great! https://codecov.io/gh/codecov/uploader/tree/0f6f6018eb13262761ae0a3c8d40b4b828b562a7

As far as the coverage drop... it doesn't like blank lines? 🤷‍♀️

@drazisil-codecov drazisil-codecov merged commit 186f731 into codecov:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants