fix: use posix path#141
Merged
drazisil-codecov merged 2 commits intocodecov:masterfrom Jun 15, 2021
drazisil:use-posix-path
Merged
fix: use posix path#141drazisil-codecov merged 2 commits intocodecov:masterfrom drazisil:use-posix-path
drazisil-codecov merged 2 commits intocodecov:masterfrom
drazisil:use-posix-path
Conversation
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 91.57% 91.39% -0.19%
==========================================
Files 30 15 -15
Lines 1092 546 -546
Branches 210 105 -105
==========================================
- Hits 1000 499 -501
+ Misses 40 20 -20
+ Partials 52 27 -25
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Contributor
Author
|
Looks great! https://codecov.io/gh/codecov/uploader/tree/0f6f6018eb13262761ae0a3c8d40b4b828b562a7 As far as the coverage drop... it doesn't like blank lines? 🤷♀️ |
hootener
approved these changes
Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
pathto usepath.posixper https://nodejs.org/dist/latest-v14.x/docs/api/path.html#path_windows_vs_posixThanks @eddiemoore !
This also runs tests on Windows prior to building.