test: switch to mock-fs and test to remove root#136
test: switch to mock-fs and test to remove root#136drazisil-codecov wants to merge 16 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 93.40% 93.53% +0.13%
==========================================
Files 30 30
Lines 1092 1114 +22
Branches 220 222 +2
==========================================
+ Hits 1020 1042 +22
Misses 40 40
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
This still does not correctly list the file paths in Windows. See https://codecov.io/api/gh/codecov/uploader/download/build?path=v4/raw/2021-06-11/A769A064AF89C4F6C6F32C7E51337952/a3ac44c700bf261da85828290173dea8dec17f21/85c5bcdd-d1e9-47ed-8d3f-3ed1d9a22a4a.txt for latest example. |
| case 'win32': | ||
| const pathObj = path.parse(projectRoot) | ||
| console.log(pathObj) | ||
| return path.join(dirPath.replace(pathObj.base, ''), file) |
There was a problem hiding this comment.
@eddiemoore What needs to happen here to change C:\Users\circleci\project\src\ci_providers\index.js into src\ci_providers\index.js
Project root: C:/Users/circleci/project
DirPath: src\ci_providers
I feel like I've tried everything.
There was a problem hiding this comment.
path.join(dirPath.replace(projectRoot, ''), file)?
Co-authored-by: Ed Moore <eddiemoore@users.noreply.github.com>
|
Fixed by #141 |
No description provided.