Skip to content

test: switch to mock-fs and test to remove root#136

Closed
drazisil-codecov wants to merge 16 commits intomasterfrom
fix-windows-paths
Closed

test: switch to mock-fs and test to remove root#136
drazisil-codecov wants to merge 16 commits intomasterfrom
fix-windows-paths

Conversation

@drazisil-codecov
Copy link
Copy Markdown
Contributor

No description provided.

@drazisil-codecov drazisil-codecov requested a review from a team as a code owner June 11, 2021 19:28
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2021

Codecov Report

Merging #136 (1194cfa) into master (67f2225) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   93.40%   93.53%   +0.13%     
==========================================
  Files          30       30              
  Lines        1092     1114      +22     
  Branches      220      222       +2     
==========================================
+ Hits         1020     1042      +22     
  Misses         40       40              
  Partials       32       32              
Flag Coverage Δ
alpine 93.53% <100.00%> (+0.13%) ⬆️
linux 93.53% <100.00%> (+0.13%) ⬆️
linux-without-git ∅ <ø> (∅)
macos 93.53% <100.00%> (+0.13%) ⬆️
macos-without-git ∅ <ø> (∅)
windows 93.53% <ø> (+0.13%) ⬆️
windows-without-git ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/helpers/files.js 93.75% <100.00%> (+0.89%) ⬆️
src/index.js 73.62% <100.00%> (+0.29%) ⬆️
...ircleci/project/src/ci_providers/provider_local.js
...leci/project/src/ci_providers/provider_travisci.js
...ci/project/src/ci_providers/provider_appveyorci.js
C:/Users/circleci/project/src/index.js
C:/Users/circleci/project/src/helpers/logger.js
...:/Users/circleci/project/src/ci_providers/index.js
...project/src/ci_providers/provider_githubactions.js
...eci/project/src/ci_providers/provider_jenkinsci.js
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67f2225...1194cfa. Read the comment docs.

@drazisil-codecov drazisil-codecov marked this pull request as draft June 11, 2021 20:13
@drazisil-codecov
Copy link
Copy Markdown
Contributor Author

case 'win32':
const pathObj = path.parse(projectRoot)
console.log(pathObj)
return path.join(dirPath.replace(pathObj.base, ''), file)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddiemoore What needs to happen here to change C:\Users\circleci\project\src\ci_providers\index.js into src\ci_providers\index.js

Project root: C:/Users/circleci/project
DirPath: src\ci_providers

I feel like I've tried everything.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path.join(dirPath.replace(projectRoot, ''), file)

?

Co-authored-by: Ed Moore <eddiemoore@users.noreply.github.com>
@drazisil-codecov drazisil-codecov marked this pull request as ready for review June 15, 2021 15:56
@drazisil-codecov
Copy link
Copy Markdown
Contributor Author

Fixed by #141

@drazisil-codecov drazisil-codecov deleted the fix-windows-paths branch June 15, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants