Skip to content

Flag silently ignored when contains invalid characters #829

@austinpray-mixpanel

Description

@austinpray-mixpanel

Describe the bug

Flags Must consist only of alphanumeric characters, '_', '-', or '.' and not exceed 45 characters

If my CI suite accidentally contains a slash or some other character, the flag is silently dropped.

To Reproduce
Steps to reproduce the behavior:

  1. Use uploader v0.2.4
  2. send a flag as -F ci/js-unit-tests
  3. The upload succeeds but the flag is blank

Expected behavior

I would expect it to bail out with "Invalid flag: flags Must consist only of alphanumeric characters, '_', '-', or '.' and not exceed 45 characters"

Additional context

If you think this is too much of a BC break, I could accept this being hidden behind a flag like CODECOV_STRICT_FLAGS=1 or something.

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions