Make suggestions to drazisil-codecov/issue829#835
Merged
mitchell-codecov merged 11 commits intodrazisil-codecov/issue829from Jul 29, 2022
Merged
Make suggestions to drazisil-codecov/issue829#835mitchell-codecov merged 11 commits intodrazisil-codecov/issue829from
mitchell-codecov merged 11 commits intodrazisil-codecov/issue829from
Conversation
|
This pull request introduces 1 alert when merging 330b035 into ef63cd4 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## drazisil-codecov/issue829 #835 +/- ##
=============================================================
- Coverage 92.15% 92.00% -0.15%
=============================================================
Files 34 34
Lines 1172 1176 +4
Branches 239 241 +2
=============================================================
+ Hits 1080 1082 +2
- Misses 62 63 +1
- Partials 30 31 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
drazisil-codecov
approved these changes
Jul 28, 2022
mitchell-codecov
added a commit
that referenced
this pull request
Aug 1, 2022
* fix: throw error when flags do not match pattern Fixes #829 * Make suggestions to drazisil-codecov/issue829 (#835) * feat: validate `flags` earlier * chore: create `isValidFlag` * refactor: `validateFlags` * refactor: use `validateFlags` * refactor: `isValidFlag` * fix: expose `isValidFlag` * chore: remove unused import * fix: filter on falsy values * fix: allow empty strings * fix: join flags * fix: validate.test.ts Co-authored-by: Mitchell Borrego <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.